linux-kernel - Re: [PATCH v2 02/17] mm: fix mapping_set_error call in me_pagecache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170412142814.GB784@bombadil.infradead.org>
Date:   Wed, 12 Apr 2017 07:28:14 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Jeff Layton <jlayton@...hat.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, tytso@....edu, jack@...e.cz,
        neilb@...e.com, viro@...iv.linux.org.uk
Subject: Re: [PATCH v2 02/17] mm: fix mapping_set_error call in
 me_pagecache_dirty

On Wed, Apr 12, 2017 at 08:05:59AM -0400, Jeff Layton wrote:
> The error code should be negative. Since this ends up in the default
> case anyway, this is harmless, but it's less confusing to negate it.
> Also, later patches will require a negative error code here.
> 
> Signed-off-by: Jeff Layton <jlayton@...hat.com>
> Reviewed-by: Ross Zwisler <ross.zwisler@...ux.intel.com>

Reviewed-by: Matthew Wilcox <mawilcox@...rosoft.com>