linux-kernel - Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170412154909.hhv3kexadbqsekkr@sirena.org.uk>
Date:   Wed, 12 Apr 2017 16:49:09 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Dong Aisheng <dongas86@...il.com>
Cc:     Dong Aisheng <aisheng.dong@....com>, linux-kernel@...r.kernel.org,
        shawnguo@...nel.org, linux-arm-kernel@...ts.infradead.org,
        kernel@...gutronix.de, lgirdwood@...il.com, yibin.gong@....com,
        Richard Zhu <hongxing.zhu@....com>
Subject: Re: [PATCH 6/6] regulator: anatop: set default voltage selector for
 pcie

On Thu, Apr 13, 2017 at 03:41:03PM +0800, Dong Aisheng wrote:
> On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote:

> > Why is this the only anatop regulator which can have this problem and
> > how do we know this is a good value?

> Anatop regulator has no separate gate bit.
> e.g.
> 00000 Power gated off
> 00001 Target core voltage = 0.725V
> ...
> So it may have no valid default voltage in case it's disabled in
> bootloader.
> e.g. regulator_enable() may not work.

That doesn't answer my question.  What I'm asking is why another anatop
regulator might not end up disabled like this one.

> The default voltage 1.100v this patch sets is defined in reference
> manual.

For the SoC you're currently looking at...  might another have a
different value?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)