linux-kernel - Re: [PATCH V3 00/16] Introduce the BFQ I/O scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0E4AC836-F950-4849-BFF7-B055FC318916@linaro.org>
Date:   Wed, 12 Apr 2017 18:08:02 +0200
From:   Paolo Valente <paolo.valente@...aro.org>
To:     Bart Van Assche <Bart.VanAssche@...disk.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "fchecconi@...il.com" <fchecconi@...il.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        Arianna Avanzini <avanzini.arianna@...il.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "tj@...nel.org" <tj@...nel.org>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>
Subject: Re: [PATCH V3 00/16] Introduce the BFQ I/O scheduler


> Il giorno 12 apr 2017, alle ore 17:30, Bart Van Assche <Bart.VanAssche@...disk.com> ha scritto:
> 
> On Wed, 2017-04-12 at 08:01 +0200, Paolo Valente wrote:
>> Where is my mistake?
> 
> I think in the Makefile. How about the patch below? Please note that I'm no
> Kbuild expert.
> 

Thank you very much for finding and fixing the bug.  I was working
exactly on that, and had got to the same solution (which I guess is
the only correct one).  I'll apply these changes and resubmit.

Thanks,
Paolo

> diff --git a/block/Makefile b/block/Makefile
> index 546066ee7fa6..b3711af6b637 100644
> --- a/block/Makefile
> +++ b/block/Makefile
> @@ -20,7 +20,8 @@ obj-$(CONFIG_IOSCHED_NOOP)    += noop-iosched.o
>  obj-$(CONFIG_IOSCHED_DEADLINE) += deadline-iosched.o
>  obj-$(CONFIG_IOSCHED_CFQ)      += cfq-iosched.o
>  obj-$(CONFIG_MQ_IOSCHED_DEADLINE)      += mq-deadline.o
> -obj-$(CONFIG_IOSCHED_BFQ)      += bfq-iosched.o bfq-wf2q.o bfq-cgroup.o
> +bfq-y                          := bfq-iosched.o bfq-wf2q.o bfq-cgroup.o
> +obj-$(CONFIG_IOSCHED_BFQ)      += bfq.o
>    obj-$(CONFIG_BLOCK_COMPAT)     += compat_ioctl.o
>  obj-$(CONFIG_BLK_CMDLINE_PARSER)       += cmdline-parser.o
>