linux-kernel - Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170412161631.d45jtyqgcky2cqxm@sirena.org.uk>
Date:   Wed, 12 Apr 2017 17:16:32 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Lucas Stach <l.stach@...gutronix.de>
Cc:     Dong Aisheng <dongas86@...il.com>,
        Dong Aisheng <aisheng.dong@....com>,
        Richard Zhu <hongxing.zhu@....com>, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de,
        yibin.gong@....com, shawnguo@...nel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 6/6] regulator: anatop: set default voltage selector for
 pcie

On Wed, Apr 12, 2017 at 06:11:54PM +0200, Lucas Stach wrote:
> Am Donnerstag, den 13.04.2017, 15:41 +0800 schrieb Dong Aisheng:

> > The default voltage 1.100v this patch sets is defined in reference
> > manual.

> Huh? Shouldn't regulator_enable bring the voltage in a range defined by
> the constraints in the DT?

As part of that process it checks what the current voltage is but with
this regulator you can't read the voltage if the regulator is powered
off and we don't just ignore that error.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)