linux-kernel - Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Apr 2017 13:08:08 +0800
From:   Jie Deng <Jie.Deng1@...opsys.com>
To:     David Miller <davem@...emloft.net>, <Jie.Deng1@...opsys.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dwc-xlgmac: add the initial ethtool support

On 2017/4/11 22:47, David Miller wrote:

> From: Jie Deng <Jie.Deng1@...opsys.com>
> Date: Tue, 11 Apr 2017 16:14:04 +0800
>
>> It is necessary to provide ethtool support for displaying and
>> modifying parameters of dwc-xlgmac.
>>
>> Signed-off-by: Jie Deng <jiedeng@...opsys.com>
> I don't see why you cannot allow the statistics to be obtained when
> the device is not running.  Similarly for other ethtool calls that
> just fetch information stored in the software state of the driver.
>
> I think your ->begin() method is way too restrictive.
Yeah, begin() seems unreasonable here. I will remove it.