linux-kernel - Re: [PATCH v3] HID: asus: support backlight on USB keyboards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1704122211390.28004@cbobk.fhfr.pm>
Date:   Wed, 12 Apr 2017 22:12:35 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Carlo Caione <carlo@...lessm.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Carlo Caione <carlo@...one.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Linux Upstreaming Team <linux@...lessm.com>
Subject: Re: [PATCH v3] HID: asus: support backlight on USB keyboards

On Wed, 12 Apr 2017, Carlo Caione wrote:

> >> +     ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev);
> >> +     if (ret < 0) {
> >> +             /* No need to have this still around */
> >> +             devm_kfree(&hdev->dev, drvdata->kbd_backlight);
> >> +             cancel_work_sync(&drvdata->kbd_backlight->work);
> >
> > Small nitpick, you don't need to call cancel_work_sync() here, nobody
> > could have called a worker. But OTOH, it doesn't hurt.
> >
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> 
> Thanks Benjamin. Who should pick this up?

I am going to.

I'll drop the cancel_work_sync() call while doing it, ok?

-- 
Jiri Kosina
SUSE Labs