linux-kernel - Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170412205229.GA13659@intel.com>
Date:   Wed, 12 Apr 2017 13:52:30 -0700
From:   "Luck, Tony" <tony.luck@...el.com>
To:     "Verma, Vishal L" <vishal.l.verma@...el.com>
Cc:     "bp@...e.de" <bp@...e.de>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "ross.zwisler@...ux.intel.com" <ross.zwisler@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from
 'atomic'

On Wed, Apr 12, 2017 at 01:27:05PM -0700, Verma, Vishal L wrote:
> >  	/* We only care about memory errors */
> >  	if (!(mce->status & MCACOD))
> >  		return NOTIFY_DONE;

N.B. that isn't a valid test that this is a memory error. You need


	if (!(m->status & 0xef80) == BIT(7))
		return NOTIFY_DONE;

See: Intel SDM Volume 3B - 15.9.2 Compound Error Codes

-Tony