linux-kernel - Re: [PATCH v2] scsi/bfa: use designated initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJ+9nm+Ojxfkc7z=y1=arSCh8Ye=aTXbvZHQwOwcrFgLA@mail.gmail.com>
Date:   Wed, 12 Apr 2017 17:21:20 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Christoph Hellwig <hch@....de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Anil Gurumurthy <anil.gurumurthy@...gic.com>,
        Sudarsana Kalluru <sudarsana.kalluru@...gic.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH v2] scsi/bfa: use designated initializers

On Thu, Mar 30, 2017 at 1:18 AM, Christoph Hellwig <hch@....de> wrote:
> On Wed, Mar 29, 2017 at 01:55:09PM -0700, Kees Cook wrote:
>> Prepare to mark sensitive kernel structures for randomization by making
>> sure they're using designated initializers. These were identified during
>> allyesconfig builds of x86, arm, and arm64, with most initializer fixes
>> extracted from grsecurity.
>>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>> ---
>> This has been updated now that struct bfa_fcs_mod_s was dropped.
>
> Can you also add designated array initializers for __port_action while
> you're at it?

Hrm? This is what the patch already does. It adds them for both
__port_action and struct bfa_module_s.

-Kees

-- 
Kees Cook
Pixel Security