linux-kernel - Re: [PATCH v3 1/1] pwm: pca9685: fix gpio-only operation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170413081555.GC3473@lahna.fi.intel.com>
Date:   Thu, 13 Apr 2017 11:15:55 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     thierry.reding@...il.com, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org, clemens.gruber@...ruber.com,
        andriy.shevchenko@...ux.intel.com,
        Sven Van Asbroeck <TheSven73@...glemail.com>
Subject: Re: [PATCH v3 1/1] pwm: pca9685: fix gpio-only operation.

On Wed, Apr 12, 2017 at 11:15:59AM -0400, Sven Van Asbroeck wrote:
> +	pm_runtime_set_active(&client->dev);
> +	/* enable will put the chip into suspend, which is what we
> +	 * want as all outputs are disabled at this point
> +	 */

This comment should also be in the standard block comment format.

Other than that, the patch looks good to me.

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>