lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 13 Apr 2017 10:44:53 +0200
From:   Peter Zijlstra <>
To:     Steven Rostedt <>
Cc:     LKML <>,
        Ingo Molnar <>,
        Andrew Morton <>,
        "Paul E. McKenney" <>,
        Thomas Gleixner <>
Subject: Re: [PATCH v2] sched: Have do_idle() call __schedule() without
 enabling preemption

On Wed, Apr 12, 2017 at 02:27:44PM -0400, Steven Rostedt wrote:
> + * schedule_idle() is similar to schedule_preempt_disable() except
> + * that it never enables preemption.

That's not right. The primary distinction is that it doesn't call

And because that function is a no-op for the idle thread, the idle
thread can do without calling that and therefore avoid the preemption

You also need a few words about fake idle threads, search play_idle()

You could also make schedule_idle() more robust by adding a WARN for the
blk_schedule_flush_plug() condition.

You Changelog is still entirely long and rambling but fails to mention
the fundamental important stuff :-(

Powered by blists - more mailing lists