linux-kernel - Re: Incorrect usage of macro ALTERNATIVE in arch/x86/include/asm/arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170413094359.7z4lksszqfqb6d6z@pd.tnic>
Date:   Thu, 13 Apr 2017 11:43:59 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Corcodel Marian <asd@...ian1000.go.ro>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: Incorrect usage of macro ALTERNATIVE in
 arch/x86/include/asm/arch_hweight.h

On Wed, Apr 12, 2017 at 05:38:59PM +0300, Corcodel Marian wrote:
> 1. Remove suppress errors message from compiler
> 
> 2 . Run make to compile kernel
> 
> Bellow is errors message from compiler:
> 
> ./arch/x86/include/asm/arch_hweight.h: In function '__arch_hweight32':
> ./arch/x86/include/asm/arch_hweight.h:31:7: error: expected string literal
> before 'ALTERNATIVE'
>   asm (ALTERNATIVE("call __sw_hweight32", POPCNT32, X86_FEATURE_POPCNT)
>        ^
> ./arch/x86/include/asm/arch_hweight.h: In function '__arch_hweight64':
> ./arch/x86/include/asm/arch_hweight.h:59:7: error: expected string literal
> before 'ALTERNATIVE'
>   asm (ALTERNATIVE("call __sw_hweight64", POPCNT64, X86_FEATURE_POPCNT)
> 
> 
> How determine contacts:
> 
> From terminal run:
> 
> asu@...-ALABAMA:~/KERNEL/test4/linux-4.6.2$ perl scripts/get_maintainer.pl
> -f arch/x86/include/asm/arch_hweight.hperl: warning: Setting locale failed.
> perl: warning: Please check that your locale settings:
>     LANGUAGE = "en",
>     LC_ALL = (unset),
>     LANG = "ro_RO.UTF-8"
>     are supported and installed on your system.
> perl: warning: Falling back to the standard locale ("C").
> Bad divisor in main::vcs_assign: 0
> Thomas Gleixner <tglx@...utronix.de> (maintainer:X86 ARCHITECTURE (32-BIT
> AND 64-BIT))
> Ingo Molnar <mingo@...hat.com> (maintainer:X86 ARCHITECTURE (32-BIT AND
> 64-BIT))
> "H. Peter Anvin" <hpa@...or.com> (maintainer:X86 ARCHITECTURE (32-BIT AND
> 64-BIT))
> x86@...nel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> "GitAuthor: Corcodel Marian" <asd@...ian1000.go.ro>
> (authored:1/1=100%,added_lines:66/66=100%)

Did you touch that file and now it fails building? Because this says there's one
commit from you touching arch/x86/include/asm/arch_hweight.h...

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.