linux-kernel - Re: [PATCH] regulator: core: Allow dummy regulators for supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170413122048.peoelbyjbwueryxc@sirena.org.uk>
Date:   Thu, 13 Apr 2017 13:20:48 +0100
From:   Mark Brown <broonie@...nel.org>
To:     "A.S. Dong" <aisheng.dong@....com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Robin Gong <yibin.gong@....com>,
        "dongas86@...il.com" <dongas86@...il.com>
Subject: Re: [PATCH] regulator: core: Allow dummy regulators for supplies

On Wed, Apr 12, 2017 at 03:33:14PM +0000, A.S. Dong wrote:

> Now we allow a supply to be a dummy regulator. But due to 
> fc42112c0eaa ("regulator: core: Propagate voltage changes to supply regulators")
> which supports propagate voltage change to supply regulator,
> then it will certainly fail if we want to configure a dummy supply.
> 
> I tried a quick fix as follows and test seemed ok.

> -       if (rdev->supply && (rdev->desc->min_dropout_uV ||
> +       if (rdev->supply && rdev->supply->rdev != dummy_regulator_rdev &&
> +                               (rdev->desc->min_dropout_uV ||

> Not sure if it's a sufficient fix.
> Please help check it.

Ah, of course.  That'll work but I don't think it's the best solution -
there are some other regulators that also won't support setting voltages
but might get used as supplies so we should do something based on the
properties of the regulator rather than based specifically on the dummy
regulator.  Let me see...

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)