lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 13 Apr 2017 15:22:00 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Moni Shoua <monis@...lanox.com>, Sagi Grimberg <sagi@...mberg.me>,
        Max Gurtovoy <maxg@...lanox.com>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        linux-rdma@...r.kernel.org, Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH] IB/rxe: Don't clamp residual length to mtu

On Thu, Apr 13, 2017 at 02:00:00PM +0200, Johannes Thumshirn wrote:
> On Thu, Apr 06, 2017 at 02:49:44PM +0200, Johannes Thumshirn wrote:
> > When reading a RDMA WRITE FIRST packet we copy the DMA length from the RDMA
> > header into the qp->resp.resid variable for later use. Later in check_rkey()
> > we clamp it to the MTU if the packet is an  RDMA WRITE packet and has a
> > residual length bigger than the MTU. Later in write_data_in() we subtract the
> > payload of the packet from the residual length. If the packet happens to have a
> > payload of exactly the MTU size we end up with a residual length of 0 despite
> > the packet not being the last in the conversation. When the next packet in the
> > conversation arrives, we don't have any residual length left and thus set the QP
>
> Hi Moni, Sagi and Max,
>
> Any comments on this?

Hi,

I'm sorry, it looks like this patch failed on the floor. We have
Passover vacation these days and many people are OOO now.

But anyway, I'll remind to Moni.

Thanks

>
> Thanks,
> 	Johannes
>
> --
> Johannes Thumshirn                                          Storage
> jthumshirn@...e.de                                +49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)

Powered by blists - more mailing lists