lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 13 Apr 2017 15:05:24 +0200
From:   Vlastimil Babka <>
To:     Michal Hocko <>,
Cc:     Andrew Morton <>,
        Mel Gorman <>,
        Andrea Arcangeli <>,
        Jerome Glisse <>,
        Reza Arbab <>,
        Yasuaki Ishimatsu <>,, Kani Toshimitsu <>,, Joonsoo Kim <>,
        Andi Kleen <>,
        David Rientjes <>,
        Daniel Kiper <>,
        Igor Mammedov <>,
        Vitaly Kuznetsov <>,
        LKML <>,
        Michal Hocko <>,
        Dan Williams <>
Subject: Re: [PATCH 4/9] mm, memory_hotplug: get rid of is_zone_device_section

On 04/10/2017 01:03 PM, Michal Hocko wrote:
> From: Michal Hocko <>
> device memory hotplug hooks into regular memory hotplug only half way.
> It needs memory sections to track struct pages but there is no
> need/desire to associate those sections with memory blocks and export
> them to the userspace via sysfs because they cannot be onlined anyway.
> This is currently expressed by for_device argument to arch_add_memory
> which then makes sure to associate the given memory range with
> ZONE_DEVICE. register_new_memory then relies on is_zone_device_section
> to distinguish special memory hotplug from the regular one. While this
> works now, later patches in this series want to move __add_zone outside
> of arch_add_memory path so we have to come up with something else.
> Add want_memblock down the __add_pages path and use it to control
> whether the section->memblock association should be done. arch_add_memory
> then just trivially want memblock for everything but for_device hotplug.
> remove_memory_section doesn't need is_zone_device_section either. We can
> simply skip all the memblock specific cleanup if there is no memblock
> for the given section.
> This shouldn't introduce any functional change.
> Cc: Dan Williams <>
> Signed-off-by: Michal Hocko <>

For the fixed version:

Acked-by: Vlastimil Babka <>

Powered by blists - more mailing lists