linux-kernel - Re: [PATCH] clk: Add requested rate to clock summary output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 Apr 2017 16:50:45 +0300
From:   Peter De Schrijver <pdeschrijver@...dia.com>
To:     Stephen Boyd <sboyd@...eaurora.org>
CC:     Michael Turquette <mturquette@...libre.com>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Alex Frid <afrid@...dia.com>
Subject: Re: [PATCH] clk: Add requested rate to clock summary output

On Wed, Apr 12, 2017 at 09:48:56AM -0700, Stephen Boyd wrote:
> On 03/22, Peter De Schrijver wrote:
> > From: Alex Frid <afrid@...dia.com>
> > 
> > Added requested rate to clock summary output and to clock dump. This is
> > useful for clock tree debugging. Also expand the clock name field in the
> > clock tree debugfs output to provide room for deep multi-tier trees like
> > on Tegra.
> > 
> > Signed-off-by: Alex Frid <afrid@...dia.com>
> > Signed-off-by: Peter De Schrijver <pdeschrijver@...dia.com>
> 
> We should print out all the consumers (struct clks) and their
> requested rates + prepare/enable counts instead. req_rate is sort
> of an internal variable that records what the last aggregated
> rate was. I'm not sure if we want to expose that to debugfs.
> 

While this certainly would provide more information, I think it would also
make the summary quite large. Hence the just printing the aggregate rate
seems a reasonable compromise. Maybe the consumers and requested rates
can be exposed in a file in the per clock directory. The prepare and enable
counts are not maintained per consumer today, so that's not possible?

Peter.

> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project