lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Apr 2017 16:53:34 +0200 From: Christoph Hellwig <hch@....de> To: Bjorn Helgaas <bhelgaas@...gle.com>, Giovanni Cabiddu <giovanni.cabiddu@...el.com>, Salvatore Benedetto <salvatore.benedetto@...el.com>, Mike Marciniszyn <mike.marciniszyn@...el.com>, Dennis Dalessandro <dennis.dalessandro@...el.com>, Derek Chickles <derek.chickles@...iumnetworks.com>, Satanand Burla <satananda.burla@...iumnetworks.com>, Felix Manlunas <felix.manlunas@...iumnetworks.com>, Raghu Vatsavayi <raghu.vatsavayi@...iumnetworks.com>, Jeff Kirsher <jeffrey.t.kirsher@...el.com> Cc: linux-pci@...r.kernel.org, qat-linux@...el.com, linux-crypto@...r.kernel.org, linux-rdma@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 2/7] PCI: call pcie_flr from reset_intel_82599_sfp_virtfn The 82599 quirk contained an outdated copy of the FLR code. Signed-off-by: Christoph Hellwig <hch@....de> --- drivers/pci/quirks.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 673683660b5c..b1775354cc69 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -3642,19 +3642,11 @@ static int reset_intel_82599_sfp_virtfn(struct pci_dev *dev, int probe) * * The 82599 supports FLR on VFs, but FLR support is reported only * in the PF DEVCAP (sec 9.3.10.4), not in the VF DEVCAP (sec 9.5). - * Therefore, we can't use pcie_flr(), which checks the VF DEVCAP. + * Thus we must call pcie_flr directly without first checking if it is + * supported. */ - - if (probe) - return 0; - - if (!pci_wait_for_pending_transaction(dev)) - dev_err(&dev->dev, "transaction is not cleared; proceeding with reset anyway\n"); - - pcie_capability_set_word(dev, PCI_EXP_DEVCTL, PCI_EXP_DEVCTL_BCR_FLR); - - msleep(100); - + if (!probe) + pcie_flr(dev); return 0; } -- 2.11.0
Powered by blists - more mailing lists