lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 13 Apr 2017 18:10:23 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Philipp Zabel <p.zabel@...gutronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     <linux-kernel@...r.kernel.org>, <kernel@...gutronix.de>
Subject: Re: [PATCH] mux: mux-gpio: fix compatible according to binding
 documentation

On 2017-04-13 16:24, Philipp Zabel wrote:
> According to the device tree binding documentation, the compatible
> should be "gpio-mux", not "mux-gpio".
> 
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> ---
>  drivers/mux/mux-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mux/mux-gpio.c b/drivers/mux/mux-gpio.c
> index b304845c4812b..227d3572e6dbf 100644
> --- a/drivers/mux/mux-gpio.c
> +++ b/drivers/mux/mux-gpio.c
> @@ -43,7 +43,7 @@ static const struct mux_control_ops mux_gpio_ops = {
>  };
>  
>  static const struct of_device_id mux_gpio_dt_ids[] = {
> -	{ .compatible = "mux-gpio", },
> +	{ .compatible = "gpio-mux", },
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(of, mux_gpio_dt_ids);
> 

Oh, crap, right you are. However, the mux patch series is not frozen yet,
and I think Greg KH will want this fixed before they are. So, I guess I'll
send a v11 of the mux series (shortly) instead of having this extra patch.

Cheers,
peda

Powered by blists - more mailing lists