linux-kernel - Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170413121530.394c6ca8@gandalf.local.home>
Date:   Thu, 13 Apr 2017 12:15:30 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Alex Shi <alex.shi@...aro.org>
Cc:     peterz@...radead.org, mingo@...hat.com, corbet@....net,
        linux-kernel@...r.kernel.org (open list:LOCKING PRIMITIVES),
        Sebastian Siewior <bigeasy@...utronix.de>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio

On Thu, 13 Apr 2017 22:02:54 +0800
Alex Shi <alex.shi@...aro.org> wrote:

> We don't need to adjust prio before new pi_waiter adding. The prio
> only need update after pi_waiter change or task normal_prio change.
> 
> Signed-off-by: Alex Shi <alex.shi@...aro.org>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Sebastian Siewior <bigeasy@...utronix.de>
> To: linux-kernel@...r.kernel.org
> To: Ingo Molnar <mingo@...hat.com>
> To: Peter Zijlstra <peterz@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> ---
>  kernel/locking/rtmutex.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c
> index 05ff685..3ee8bc1 100644
> --- a/kernel/locking/rtmutex.c
> +++ b/kernel/locking/rtmutex.c
> @@ -973,7 +973,6 @@ static int task_blocks_on_rt_mutex(struct rt_mutex *lock,
>  		return -EDEADLK;
>  
>  	raw_spin_lock(&task->pi_lock);
> -	__rt_mutex_adjust_prio(task);

Yeah, I'm not sure why this is called here.

-- Steve

>  	waiter->task = task;
>  	waiter->lock = lock;
>  	waiter->prio = task->prio;