linux-kernel - Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170413.124023.506336754463093992.davem@davemloft.net>
Date:   Thu, 13 Apr 2017 12:40:23 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     niklas.cassel@...s.com
Cc:     peppe.cavallaro@...com, alexandre.torgue@...com,
        Joao.Pinto@...opsys.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, niklass@...s.com
Subject: Re: [PATCH net-next] net: stmmac: set total length of the packet
 to be transmitted in TDES3

From: Niklas Cassel <niklas.cassel@...s.com>
Date: Mon, 10 Apr 2017 20:33:29 +0200

> From: Niklas Cassel <niklas.cassel@...s.com>
> 
> Field FL/TPL in register TDES3 is not correctly set on GMAC4.
> TX appears to be functional on GMAC 4.10a even if this field is not set,
> however, to avoid relying on undefined behavior, set the length in TDES3.
> 
> The field has a different meaning depending on if the TSE bit in TDES3
> is set or not (TSO). However, regardless of the TSE bit, the field is
> not optional. The field is already set correctly when the TSE bit is set.
> 
> Since there is no limit for the number of descriptors that can be
> used for a single packet, the field should be set to the sum of
> the buffers contained in:
> [<desc with First Descriptor bit set> ... <desc n> ...
> <desc with Last Descriptor bit set>], which should be equal to skb->len.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@...s.com>

Applied, thanks.