lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 13 Apr 2017 16:35:34 -0300
From:   Arnaldo Carvalho de Melo <>
To:     Ingo Molnar <>
        David Carrillo-Cisneros <>,
        Alexander Shishkin <>,
        Andi Kleen <>, He Kuang <>,
        Jiri Olsa <>,
        Masami Hiramatsu <>,
        Paul Turner <>,
        Peter Zijlstra <>,
        Simon Que <>,
        Stephane Eranian <>,
        Wang Nan <>,
        Arnaldo Carvalho de Melo <>
Subject: [PATCH 5/7] tools build: Fix feature detection redefinion of build flags

From: David Carrillo-Cisneros <>

This change is a follow up of

The patch above avoided redefining CC, CXX and PKG_CONFIG in feature
detection. The patch was not merged due to a unsolved concern with the
-MD flag.

Later, commit c8c188679ccf ("tools build: Use the same CC for feature
detection and actual build") did the change for CC and CXX but not

This patch makes PKG_CONFIG consistent with CC and CXX and moves the -MD
to CFLAGS, as suggested by Jiri in the thread above.

Signed-off-by: David Carrillo-Cisneros <>
Cc: Alexander Shishkin <>
Cc: Andi Kleen <>
Cc: He Kuang <>
Cc: Jiri Olsa <>
Cc: Masami Hiramatsu <>
Cc: Paul Turner <>
Cc: Peter Zijlstra <>
Cc: Simon Que <>
Cc: Stephane Eranian <>
Cc: Wang Nan <>
Signed-off-by: Arnaldo Carvalho de Melo <>
 tools/build/feature/Makefile | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
index 523e587fe05f..e35e4e5ad192 100644
--- a/tools/build/feature/Makefile
+++ b/tools/build/feature/Makefile
@@ -53,17 +53,17 @@ FILES=                                          \
 FILES := $(addprefix $(OUTPUT),$(FILES))
 LLVM_CONFIG ?= llvm-config
 all: $(FILES)
-__BUILD = $(CC) $(CFLAGS) -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)
+__BUILD = $(CC) $(CFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.c,$(@F)) $(LDFLAGS)
   BUILD = $(__BUILD) > $(@:.bin=.make.output) 2>&1
-__BUILDXX = $(CXX) $(CXXFLAGS) -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$(@F)) $(LDFLAGS)
+__BUILDXX = $(CXX) $(CXXFLAGS) -MD -Wall -Werror -o $@ $(patsubst %.bin,%.cpp,$(@F)) $(LDFLAGS)
   BUILDXX = $(__BUILDXX) > $(@:.bin=.make.output) 2>&1

Powered by blists - more mailing lists