linux-kernel - Re: [PATCH 2/9] mm, memory_hotplug: use node instead of zone in can_online_high

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c2fab88-f49d-b08b-b650-e91d7121a760@gmail.com>
Date:   Thu, 13 Apr 2017 15:45:46 -0400
From:   YASUAKI ISHIMATSU <yasu.isimatu@...il.com>
To:     Michal Hocko <mhocko@...nel.org>, linux-mm@...ck.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Mel Gorman <mgorman@...e.de>, Vlastimil Babka <vbabka@...e.cz>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Jerome Glisse <jglisse@...hat.com>,
        Reza Arbab <arbab@...ux.vnet.ibm.com>, qiuxishi@...wei.com,
        Kani Toshimitsu <toshi.kani@....com>, slaoub@...il.com,
        Joonsoo Kim <js1304@...il.com>,
        Andi Kleen <ak@...ux.intel.com>,
        David Rientjes <rientjes@...gle.com>,
        Daniel Kiper <daniel.kiper@...cle.com>,
        Igor Mammedov <imammedo@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH 2/9] mm, memory_hotplug: use node instead of zone in
 can_online_high_movable



On 04/10/2017 07:03 AM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@...e.com>
> 
> the primary purpose of this helper is to query the node state so use
> the node id directly. This is a preparatory patch for later changes.
> 
> This shouldn't introduce any functional change
> 
> Signed-off-by: Michal Hocko <mhocko@...e.com>
> ---

Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>

Thanks,
Yasuaki Ishimatsu

>  mm/memory_hotplug.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 9ed251811ec3..342332f29364 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -940,15 +940,15 @@ static int online_pages_range(unsigned long start_pfn, unsigned long nr_pages,
>   * When CONFIG_MOVABLE_NODE, we permit onlining of a node which doesn't have
>   * normal memory.
>   */
> -static bool can_online_high_movable(struct zone *zone)
> +static bool can_online_high_movable(int nid)
>  {
>  	return true;
>  }
>  #else /* CONFIG_MOVABLE_NODE */
>  /* ensure every online node has NORMAL memory */
> -static bool can_online_high_movable(struct zone *zone)
> +static bool can_online_high_movable(int nid)
>  {
> -	return node_state(zone_to_nid(zone), N_NORMAL_MEMORY);
> +	return node_state(nid, N_NORMAL_MEMORY);
>  }
>  #endif /* CONFIG_MOVABLE_NODE */
>  
> @@ -1082,7 +1082,7 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ
>  
>  	if ((zone_idx(zone) > ZONE_NORMAL ||
>  	    online_type == MMOP_ONLINE_MOVABLE) &&
> -	    !can_online_high_movable(zone))
> +	    !can_online_high_movable(pfn_to_nid(pfn)))
>  		return -EINVAL;
>  
>  	if (online_type == MMOP_ONLINE_KERNEL) {
>