linux-kernel - RE: [PATCH] scsi: storvsc: remove return at end of void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM5PR03MB249034710FBFFF705EEA480CA0020@DM5PR03MB2490.namprd03.prod.outlook.com>
Date:   Thu, 13 Apr 2017 23:28:54 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     Miguel Bernal Marin <miguel.bernal.marin@...ux.intel.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>
Subject: RE: [PATCH] scsi: storvsc: remove return at end of void function



> -----Original Message-----
> From: Miguel Bernal Marin [mailto:miguel.bernal.marin@...ux.intel.com]
> Sent: Thursday, March 16, 2017 12:00 AM
> To: KY Srinivasan <kys@...rosoft.com>; Martin K. Petersen
> <martin.petersen@...cle.com>
> Cc: linux-kernel@...r.kernel.org; linux-scsi@...r.kernel.org;
> devel@...uxdriverproject.org; Haiyang Zhang <haiyangz@...rosoft.com>;
> Stephen Hemminger <sthemmin@...rosoft.com>; James E.J. Bottomley
> <jejb@...ux.vnet.ibm.com>
> Subject: [PATCH] scsi: storvsc: remove return at end of void function
> 
> storvsc_on_channel_callback is a void function and the return
> statement at the end is not useful.
> 
> Found with checkpatch.
> 
> Signed-off-by: Miguel Bernal Marin <miguel.bernal.marin@...ux.intel.com>

Reviewed-by:  K. Y. Srinivasan <kys@...rosoft.com>

> ---
>  drivers/scsi/storvsc_drv.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 3d70d1cf49a3..538f3e131275 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1191,8 +1191,6 @@ static void storvsc_on_channel_callback(void
> *context)
>  			break;
>  		}
>  	} while (1);
> -
> -	return;
>  }
> 
>  static int storvsc_connect_to_vsp(struct hv_device *device, u32 ring_size,
> --
> 2.12.0