lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Apr 2017 08:58:50 +0900 From: Simon Horman <horms@...ge.net.au> To: Alexandre Belloni <alexandre.belloni@...e-electrons.com> Cc: Javier Martinez Canillas <javier@....samsung.com>, Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>, Russell King <linux@...linux.org.uk>, linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>, Peter Rosin <peda@...ntia.se>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM On Thu, Apr 13, 2017 at 11:20:59PM +0200, Alexandre Belloni wrote: > On 13/04/2017 at 18:09:56 -0300, Javier Martinez Canillas wrote: > > Hello Peter, > > > > On 04/13/2017 05:43 PM, Peter Rosin wrote: > > > On 2017-04-13 20:28, Javier Martinez Canillas wrote: > > > > [snip] > > > > >> > > >> eeprom@50 { > > >> - compatible = "nxp,24c02"; > > >> + compatible = "nxp,24c02","atmel,24c02"; > > >> reg = <0x50>; > > >> pagesize = <16>; > > >> }; > > >> > > > > > > Sure, in principle. But not having a space after the commas is a real OCD > > > trigger for me. My spine is rotating... :-) > > > > > > > Right, Geert already pointed out. It's something I missed in my sed script > > so I got it wrong in all the DTS :( > > > > I'll fix my script and send a v2. > > > > That would be v3, right? ;) > > > > Anyway, with those whitespace fixes (and without them too, but please): > > > Acked-by: Peter Rosin <peda@...ntia.se> > > > > > > > Thanks for the review! > > > > I'd like to be copied on the first patches to ensure they are applied > before applying that one. (Also, it is probably too late for 4.12 anyway > because we are past rc6). Ditto
Powered by blists - more mailing lists