linux-kernel - Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170414092705.GA1944@kroah.com>
Date:   Fri, 14 Apr 2017 11:27:05 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Vincent Legoll <vincent.legoll@...il.com>
Cc:     arve@...roid.com, riandrews@...roid.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Make ANDROID a menuconfig to ease disabling it all

On Fri, Apr 14, 2017 at 11:04:21AM +0200, Vincent Legoll wrote:
> No need to get into the submenu to disable all ANDROID-related config entries

I don't understand this, what exactly do you mean?

> 
> Signed-off-by: Vincent Legoll <vincent.legoll@...il.com>
> ---
>  drivers/android/Kconfig | 12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig
> index a82fc02..c2b6c37 100644
> --- a/drivers/android/Kconfig
> +++ b/drivers/android/Kconfig
> @@ -1,15 +1,11 @@
> -menu "Android"
> -
> -config ANDROID
> +menuconfig ANDROID
>  	bool "Android Drivers"
>  	---help---
>  	  Enable support for various drivers needed on the Android platform
>  
> -if ANDROID
> -
>  config ANDROID_BINDER_IPC
>  	bool "Android Binder IPC Driver"
> -	depends on MMU
> +	depends on ANDROID && MMU
>  	default n
>  	---help---
>  	  Binder is used in Android for both communication between processes,
> @@ -43,7 +39,3 @@ config ANDROID_BINDER_IPC_32BIT
>  	  earlier).
>  
>  	  Note that enabling this will break newer Android user-space.
> -
> -endif # if ANDROID
> -
> -endmenu

There are other ANDROID config options in the kernel other than right
here, so having a "menu" is a bit odd, right?

thanks,

greg k-h