linux-kernel - Re: [PATCH] ARM: dts: at91: use correct compatible for the gpio mux controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170414100705.tiltc433lidqzcr2@piout.net>
Date:   Fri, 14 Apr 2017 12:07:05 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Peter Rosin <peda@...ntia.se>
Cc:     linux-kernel@...r.kernel.org,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: at91: use correct compatible for the gpio mux
 controller

On 13/04/2017 at 23:22:58 +0200, Peter Rosin wrote:
> The compatible string for a gpio based mux controller is "gpio-mux",
> and nothing else.
> 
> Fixes: 29dd89418007 ("ARM: dts: at91: add envelope detector mux to the Axentia TSE-850")
> Signed-off-by: Peter Rosin <peda@...ntia.se>
> ---
>  arch/arm/boot/dts/at91-tse850-3.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hi!
> 
> The compatible string for the gpio based mux changed along the way (on
> request from Rob) but I failed to update the implementation in the
> gpio-mux driver when I made that change. Consequently, I didn't notice
> that I didn't update the compatible string here either, since it all
> continued to work in my tests...
> 
> The compatible string in the gpio-mux driver is being fixed to match
> documentation, so this of course needs fixing too. No TSE-850 devices
> are affected, except for the one on my desk.
> 
> Sorry for the churn.
> 

So, I folded that one in the previous one and updated my pull request.
Hopefully this will be OK.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com