linux-kernel - Re: [PATCH] Make FPGA a menuconfig to ease disabling it all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f141046-1645-90ac-61b7-b93b08a10ad1@infradead.org>
Date:   Fri, 14 Apr 2017 08:26:19 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Vincent Legoll <vincent.legoll@...il.com>,
        linux-kernel@...r.kernel.org, atull@...nsource.altera.com,
        moritz.fischer@...us.com, linux-fpga@...r.kernel.org
Subject: Re: [PATCH] Make FPGA a menuconfig to ease disabling it all

On 04/14/17 02:06, Vincent Legoll wrote:
> No need to get into the submenu to disable all FPGA-related config entries
> 
> Signed-off-by: Vincent Legoll <vincent.legoll@...il.com>
> ---
>  drivers/fpga/Kconfig | 21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index ce861a2..fa1a95e 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -2,32 +2,30 @@
>  # FPGA framework configuration
>  #
>  
> -menu "FPGA Configuration Support"
> -
> -config FPGA
> +menuconfig FPGA
>  	tristate "FPGA Configuration Framework"
>  	help
>  	  Say Y here if you want support for configuring FPGAs from the
>  	  kernel.  The FPGA framework adds a FPGA manager class and FPGA
>  	  manager drivers.
>  
> -if FPGA
> -

why not leave the "if FPGA" end "endif # FPGA" lines
and not add "depends on FPGA" to each entry?


>  config FPGA_REGION
>  	tristate "FPGA Region"
> -	depends on OF && FPGA_BRIDGE
> +	depends on FPGA && OF && FPGA_BRIDGE
>  	help
>  	  FPGA Regions allow loading FPGA images under control of
>  	  the Device Tree.
>  
>  config FPGA_MGR_SOCFPGA
>  	tristate "Altera SOCFPGA FPGA Manager"
> +	depends on FPGA
>  	depends on ARCH_SOCFPGA || COMPILE_TEST
>  	help
>  	  FPGA manager driver support for Altera SOCFPGA.
>  
>  config FPGA_MGR_SOCFPGA_A10
>  	tristate "Altera SoCFPGA Arria10"
> +	depends on FPGA
>  	depends on ARCH_SOCFPGA || COMPILE_TEST
>  	select REGMAP_MMIO
>  	help
> @@ -35,6 +33,7 @@ config FPGA_MGR_SOCFPGA_A10
>  
>  config FPGA_MGR_ZYNQ_FPGA
>  	tristate "Xilinx Zynq FPGA"
> +	depends on FPGA
>  	depends on ARCH_ZYNQ || COMPILE_TEST
>  	depends on HAS_DMA
>  	help
> @@ -42,27 +41,23 @@ config FPGA_MGR_ZYNQ_FPGA
>  
>  config FPGA_BRIDGE
>  	tristate "FPGA Bridge Framework"
> -	depends on OF
> +	depends on FPGA && OF
>  	help
>  	  Say Y here if you want to support bridges connected between host
>  	  processors and FPGAs or between FPGAs.
>  
>  config SOCFPGA_FPGA_BRIDGE
>  	tristate "Altera SoCFPGA FPGA Bridges"
> -	depends on ARCH_SOCFPGA && FPGA_BRIDGE
> +	depends on FPGA && ARCH_SOCFPGA && FPGA_BRIDGE
>  	help
>  	  Say Y to enable drivers for FPGA bridges for Altera SOCFPGA
>  	  devices.
>  
>  config ALTERA_FREEZE_BRIDGE
>  	tristate "Altera FPGA Freeze Bridge"
> -	depends on ARCH_SOCFPGA && FPGA_BRIDGE
> +	depends on FPGA && ARCH_SOCFPGA && FPGA_BRIDGE
>  	help
>  	  Say Y to enable drivers for Altera FPGA Freeze bridges.  A
>  	  freeze bridge is a bridge that exists in the FPGA fabric to
>  	  isolate one region of the FPGA from the busses while that
>  	  region is being reprogrammed.
> -
> -endif # FPGA
> -
> -endmenu
> 


-- 
~Randy