linux-kernel - [tip:irq/core] kernel/irq: Use cpumask_available() for check of cpumask variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-31299f44f42dd8dbc5ed200d3064f9c6ddbd3447@git.kernel.org>
Date:   Fri, 14 Apr 2017 10:55:28 -0700
From:   tip-bot for Matthias Kaehlcke <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     mka@...omium.org, hpa@...or.com, mingo@...nel.org,
        akpm@...ux-foundation.org, md@...gle.com, ghackmann@...gle.com,
        rusty@...tcorp.com.au, linux-kernel@...r.kernel.org,
        tglx@...utronix.de, grundler@...omium.org
Subject: [tip:irq/core] kernel/irq: Use cpumask_available() for check of
 cpumask variable

Commit-ID:  31299f44f42dd8dbc5ed200d3064f9c6ddbd3447
Gitweb:     http://git.kernel.org/tip/31299f44f42dd8dbc5ed200d3064f9c6ddbd3447
Author:     Matthias Kaehlcke <mka@...omium.org>
AuthorDate: Wed, 12 Apr 2017 11:20:30 -0700
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Fri, 14 Apr 2017 19:50:47 +0200

kernel/irq: Use cpumask_available() for check of cpumask variable

This fixes the following clang warning when CONFIG_CPUMASK_OFFSTACK=n:

kernel/irq/manage.c:839:28: error: address of array
'desc->irq_common_data.affinity' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]

Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
Cc: Grant Grundler <grundler@...omium.org>
Cc: Rusty Russell <rusty@...tcorp.com.au>
Cc: Greg Hackmann <ghackmann@...gle.com>
Cc: Michael Davidson <md@...gle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Link: http://lkml.kernel.org/r/20170412182030.83657-2-mka@chromium.org
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

---
 kernel/irq/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index a4afe5c..155e3c3 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -852,7 +852,7 @@ irq_thread_check_affinity(struct irq_desc *desc, struct irqaction *action)
 	 * This code is triggered unconditionally. Check the affinity
 	 * mask pointer. For CPU_MASK_OFFSTACK=n this is optimized out.
 	 */
-	if (desc->irq_common_data.affinity)
+	if (cpumask_available(desc->irq_common_data.affinity))
 		cpumask_copy(mask, desc->irq_common_data.affinity);
 	else
 		valid = false;