linux-kernel - Re: [PATCH v2] PCI: Make PCI_ROM_ADDRESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170414193605.GN28657@google.com>
Date:   Fri, 14 Apr 2017 12:36:05 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, Mason <slash.tmp@...e.fr>,
        Grant Grundler <grundler@...omium.org>,
        Greg Hackmann <ghackmann@...gle.com>,
        Michael Davidson <md@...gle.com>
Subject: Re: [PATCH v2] PCI: Make PCI_ROM_ADDRESS_MASK a 32-bit constant

El Fri, Apr 14, 2017 at 10:43:40AM -0500 Bjorn Helgaas ha dit:

> On Tue, Apr 11, 2017 at 10:56:58AM -0700, Matthias Kaehlcke wrote:
> > A 64-bit value is not needed since a PCI ROM address consists in 32 bits.
> > This fixes a clang warning about "implicit conversion from 'unsigned
> > long' to 'u32'".
> > 
> > Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> > ---
> > Changes in v2:
> > - Define PCI_ROM_ADDRESS_MASK as a 32-bit constant instead of using a cast
> > - Updated commit message
> > 
> >  include/uapi/linux/pci_regs.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
> > index 634c9c44ed6c..fff521c9458c 100644
> > --- a/include/uapi/linux/pci_regs.h
> > +++ b/include/uapi/linux/pci_regs.h
> > @@ -114,7 +114,7 @@
> >  #define PCI_SUBSYSTEM_ID	0x2e
> >  #define PCI_ROM_ADDRESS		0x30	/* Bits 31..11 are address, 10..1 reserved */
> >  #define  PCI_ROM_ADDRESS_ENABLE	0x01
> > -#define PCI_ROM_ADDRESS_MASK	(~0x7ffUL)
> > +#define PCI_ROM_ADDRESS_MASK	(~0x7ffU)
> 
> Does this mean we can remove the "(u32)" casts in __pci_read_base() and
> pci_std_update_resource()?

Indeed

> If so, can you do that in the same patch?

Will do

Matthias