linux-kernel - Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12228.1492210765@warthog.procyon.org.uk>
Date:   Fri, 14 Apr 2017 23:59:25 +0100
From:   David Howells <dhowells@...hat.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     dhowells@...hat.com, LKML <linux-kernel@...r.kernel.org>,
        gnomes@...rguk.ukuu.org.uk, gregkh@...uxfoundation.org,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        linux-security-module@...r.kernel.org, keyrings@...r.kernel.org,
        Jens Rottmann <JRottmann@...PERTEmbedded.de>,
        Andres Salomon <dilinger@...ued.net>
Subject: Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

Thomas Gleixner <tglx@...utronix.de> wrote:

> > -module_param_named(irq, timer_irq, int, 0644);
> > +module_param_hw_named(irq, timer_irq, int, irq, 0644);
> >  MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT ticks.");
> 
> I'm not sure about this. AFAIR the parameter is required to work on
> anything else than some arbitrary hardware which has it mapped to 0.

Should it then be set through in-kernel platform initialisation since the
AMD Geode is an embedded chip?

Btw, is it possible to use IRQ grants to prevent a device that has limited IRQ
options from being drivable?

David