linux-kernel - NFC-FDP: Completion of error handling around fdp_nci_i2c_read_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <235c865e-b66f-9fb7-2f8e-93c62cacb988@users.sourceforge.net>
Date:   Sat, 15 Apr 2017 09:51:38 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     linux-wireless@...r.kernel.org,
        Aloisio Almeida Jr <aloisio.almeida@...nbossa.org>,
        Christophe Ricard <christophe.ricard@...il.com>,
        Lauro Ramos Venancio <lauro.venancio@...nbossa.org>,
        Robert Dolca <robert.dolca@...el.com>,
        Samuel Ortiz <sameo@...ux.intel.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: NFC-FDP: Completion of error handling around
 fdp_nci_i2c_read_device_properties()

Hello,

I have noticed that the function “fdp_nci_i2c_read_device_properties” does not
contain a null pointer check after a call of the function “devm_kmalloc”.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/nfc/fdp/i2c.c?h=v4.10#n234

How do you think about to add a corresponding check and adjust the function
return type there?

Regards,
Markus