linux-kernel - Re: [PATCH] nfc: fix get_unaligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170416224537.GB694@zurbaran.ger.intel.com>
Date:   Mon, 17 Apr 2017 00:45:49 +0200
From:   Samuel Ortiz <sameo@...ux.intel.com>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] nfc: fix get_unaligned_...() misuses

On Thu, Apr 06, 2017 at 05:58:59PM +0100, Al Viro wrote:
> On Thu, Apr 06, 2017 at 05:48:47PM +0100, Al Viro wrote:
> > * use unaligned.h, not unaligned/access_ok.h
> 
> ... which got misspelled in that patch, sorry...  Fixed variant follows:
> 
> commit b3e79ba1708c9b74781079c9f8617448fce36b51
> Author: Al Viro <viro@...iv.linux.org.uk>
> Date:   Thu Apr 6 12:42:14 2017 -0400
> 
>     nfc: fix get_unaligned_...() misuses
>     
>     * use unaligned.h, not unaligned/access_ok.h
>     * if a local variable of type uint16_t is unaligned, your compiler is FUBAR
>     * the whole point of get_unaligned_... is to avoid memcpy + ..._to_cpu().
>       Using it *after* memcpy() (into aligned object, no less) is pointless.
>     
>     Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
Partly applied to nfc-next. The unaligned/access_ok.h replacements were
already applied.

Cheers,
Samuel.