linux-kernel - Re: pinctrl: imx: Checking reuse of grouping functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAMH-ysVX+ZX-+nEF2kyrAKqhrkaZisBKiZuv6fAZUrKk3-ZDg@mail.gmail.com>
Date:   Mon, 17 Apr 2017 10:25:58 +0200
From:   Gary Bisson <gary.bisson@...ndarydevices.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-gpio@...r.kernel.org, Alexander Shiyan <shc_work@...l.ru>,
        Fabio Estevam <fabio.estevam@....com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Peng Fan <van.freenix@...il.com>,
        Tony Lindgren <tony@...mide.com>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: pinctrl: imx: Checking reuse of grouping functionality

Hi Markus, All,

On Sat, Apr 15, 2017 at 9:55 PM, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
> Hello,
>
> A preprocessor symbol like “CONFIG_GENERIC_PINCTRL_GROUPS” was introduced
> by the commit c033a718f615b6b3ddc83ce3e0a217c30bd09cb5 (“pinctrl: stricten up
> generic group code”) on 2017-01-03. Some functions are only available then
> when this macro is defined.

Yes because the pinctrl driver can be used without this configuration
by some drivers.

> I have got the impression that the corresponding programming interface is used
> by the source file “drivers/pinctrl/freescale/pinctrl-imx.c” unconditionally.
> How do you think about to extend specifications for conditional compilation there?

However the imx pinctrl driver _absolutely_ needs this configuration
to work. That is why it is selected automatically when the driver is
enabled [1].

Therefore it isn't possible to build the driver without
GENERIC_PINCTRL_GROUPS and so adding conditions is not necessary.

Regards,
Gary

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/pinctrl/freescale/Kconfig#n3