linux-kernel - Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170417.105947.202929252465875756.davem@davemloft.net>
Date:   Mon, 17 Apr 2017 10:59:47 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     w.bumiller@...xmox.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        jhs@...atatu.com
Subject: Re: [RFC PATCH linux 0/2] net sched actions: access to
 uninitialized data and error handling

From: Wolfgang Bumiller <w.bumiller@...xmox.com>
Date: Wed, 12 Apr 2017 16:21:38 +0200

> Commit 1045ba77a ("net sched actions: Add support for user cookies")
> added code to net/sched/act_api.c's tcf_action_init_1 using the `tb`
> nlattr array unconditionally, while it was otherwise used as well as
> initialized only when `name == NULL`:
...
> I'm not sure why the TC_ACT_COOKIE code was added to tcf_action_init_1
> where it is now. It makes me think that it's supposed to be available
> universally, but the `name == NULL` check for how nla is used or passed
> to ->init() shows that the there are various different TC_ACT_* enums in
> use at this point, hence the 'RFC' part of the patches, I'm not that
> familiar with the code yet.

Jamal please review this.