linux-kernel - Re: [PATCH resend 3/4] uapi glibc compat: Do not check for __USE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170417.125542.69056178938392687.davem@davemloft.net>
Date:   Mon, 17 Apr 2017 12:55:42 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     hauke@...ke-m.de
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        jarod@...hat.com, jogo@...nwrt.org, david.heidelberger@...t.cz,
        maillist-linux@...fooze.de, mikko.rapeli@....fi,
        dwmw2@...radead.org
Subject: Re: [PATCH resend 3/4] uapi glibc compat: Do not check for
 __USE_MISC

From: Hauke Mehrtens <hauke@...ke-m.de>
Date: Wed, 12 Apr 2017 22:31:02 +0200

> __USE_MISC is glibc specific and not available in musl libc. Only do
> this check when glibc is used. This fixes a problem with musl libc.
> 
> Acked-by: Mikko Rapeli <mikko.rapeli@....fi>
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>

You yourself introduce this problem in patch #1.

The code before patch #1 was perfectly fine, as this code block only
existing in an area protected by __GLIBC__.

So you have to redo these patches such that you deal with all of
the fallout from changing __GLIBC__ into !__KERNEL__ at the same
time that you make that change.

Thanks.