linux-kernel - Re: [PATCH] scsi: storvsc: Allow only one remove lun work item to be issued per lun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58F51B16.1070202@redhat.com>
Date:   Mon, 17 Apr 2017 15:44:22 -0400
From:   Cathy Avery <cavery@...hat.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     kys@...rosoft.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, sthemmin@...rosoft.com,
        haiyangz@...rosoft.com, devel@...uxdriverproject.org,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] scsi: storvsc: Allow only one remove lun work item to be
 issued per lun

On 04/15/2017 10:06 AM, Christoph Hellwig wrote:
> Just add a singlethreaded workqueue for storvsc_handle_error and you'll
> get serialization for all error handling for free.

The problem I am seeing is that many work items can be queued up for the 
same lun before it goes away. The single threaded queue would have to allow
for only a queue of one and no more. Either that or each work item for a 
particular lun must have the same memory address so it gets
rejected if it you try to queue a remove to the same lun twice.

Maybe I am not understanding your suggestion correctly.

Thanks,

Cathy