linux-kernel - Re: [PATCH 3.18 010/145] sctp: avoid BUG_ON on sctp_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8bd33bf-178a-4797-5173-524a15a636ee@gmail.com>
Date:   Mon, 17 Apr 2017 17:00:50 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org, Alexander Popov <alex.popov@...ux.com>,
        Xin Long <lucien.xin@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 3.18 010/145] sctp: avoid BUG_ON on sctp_wait_for_sndbuf



Em 16-04-2017 07:48, Greg Kroah-Hartman escreveu:
> 3.18-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> 
> 
> [ Upstream commit 2dcab598484185dea7ec22219c76dcdd59e3cb90 ]


Hi Greg. Are you also including dfcb9f4f99f1 ("sctp: deny peeloff 
operation on asocs with threads sleeping on it")
It's a follow-up fix for this one, would be good to have it too.

> 
> Alexander Popov reported that an application may trigger a BUG_ON in
> sctp_wait_for_sndbuf if the socket tx buffer is full, a thread is
> waiting on it to queue more data and meanwhile another thread peels off
> the association being used by the first thread.
> 
> This patch replaces the BUG_ON call with a proper error handling. It
> will return -EPIPE to the original sendmsg call, similarly to what would
> have been done if the association wasn't found in the first place.
> 
> Acked-by: Alexander Popov <alex.popov@...ux.com>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> Reviewed-by: Xin Long <lucien.xin@...il.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>   net/sctp/socket.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- a/net/sctp/socket.c
> +++ b/net/sctp/socket.c
> @@ -6962,7 +6962,8 @@ static int sctp_wait_for_sndbuf(struct s
>   		 */
>   		release_sock(sk);
>   		current_timeo = schedule_timeout(current_timeo);
> -		BUG_ON(sk != asoc->base.sk);
> +		if (sk != asoc->base.sk)
> +			goto do_error;
>   		lock_sock(sk);
>   
>   		*timeo_p = current_timeo;
> 
>