linux-kernel - Re: [PATCH] um: Include kbuild.h instead of duplicating its macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170417203738.GQ28657@google.com>
Date:   Mon, 17 Apr 2017 13:37:38 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Jeff Dike <jdike@...toit.com>, Richard Weinberger <richard@....at>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>
Cc:     user-mode-linux-devel@...ts.sourceforge.net,
        user-mode-linux-user@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org,
        Masahiro Yamada <yamada.masahiro@...ionext.com>
Subject: Re: [PATCH] um: Include kbuild.h instead of duplicating its macros

El Mon, Apr 03, 2017 at 12:54:58PM -0700 Matthias Kaehlcke ha dit:

> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>  arch/x86/um/shared/sysdep/kernel-offsets.h | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/arch/x86/um/shared/sysdep/kernel-offsets.h b/arch/x86/um/shared/sysdep/kernel-offsets.h
> index 46a9df99f3c5..7e1d35b6ad5c 100644
> --- a/arch/x86/um/shared/sysdep/kernel-offsets.h
> +++ b/arch/x86/um/shared/sysdep/kernel-offsets.h
> @@ -2,16 +2,9 @@
>  #include <linux/sched.h>
>  #include <linux/elf.h>
>  #include <linux/crypto.h>
> +#include <linux/kbuild.h>
>  #include <asm/mman.h>
>  
> -#define DEFINE(sym, val) \
> -	asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> -
> -#define BLANK() asm volatile("\n->" : : )
> -
> -#define OFFSET(sym, str, mem) \
> -	DEFINE(sym, offsetof(struct str, mem));
> -
>  void foo(void)
>  {
>  #include <common-offsets.h>
> -- 

Ping, any comment on this patch?

Cheers

Matthias