linux-kernel - Re: [PATCH] hidma_mgmt_sys: Use devm_kmalloc_array() in hidma_mgmt_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21cb2036-2bdb-9024-a07b-a72dab747b44@codeaurora.org>
Date:   Mon, 17 Apr 2017 18:23:33 -0400
From:   Sinan Kaya <okaya@...eaurora.org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        dmaengine@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-soc@...r.kernel.org, Andy Gross <andy.gross@...aro.org>,
        Dan Williams <dan.j.williams@...el.com>,
        David Brown <david.brown@...aro.org>,
        Vinod Koul <vinod.koul@...el.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] hidma_mgmt_sys: Use devm_kmalloc_array() in
 hidma_mgmt_init_sys()

On 4/17/2017 4:55 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 17 Apr 2017 22:42:40 +0200
> 
> * A multiplication for the size determination of a memory allocation
>   indicated that an array data structure should be processed.
>   Thus use the corresponding function "devm_kmalloc_array".
> 
>   This issue was detected by using the Coccinelle software.
> 
> * Delete the local variable "required" which became unnecessary
>   with this refactoring.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/dma/qcom/hidma_mgmt_sys.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/qcom/hidma_mgmt_sys.c b/drivers/dma/qcom/hidma_mgmt_sys.c
> index d61f1068a34b..e7222a0e9ba4 100644
> --- a/drivers/dma/qcom/hidma_mgmt_sys.c
> +++ b/drivers/dma/qcom/hidma_mgmt_sys.c
> @@ -245,11 +245,12 @@ int hidma_mgmt_init_sys(struct hidma_mgmt_dev *mdev)
>  {
>  	unsigned int i;
>  	int rc;
> -	int required;
>  	struct kobject *chanops;
>  
> -	required = sizeof(*mdev->chroots) * mdev->dma_channels;
> -	mdev->chroots = devm_kmalloc(&mdev->pdev->dev, required, GFP_KERNEL);
> +	mdev->chroots = devm_kmalloc_array(&mdev->pdev->dev,
> +					   mdev->dma_channels,
> +					   sizeof(*mdev->chroots),
> +					   GFP_KERNEL);
>  	if (!mdev->chroots)
>  		return -ENOMEM;
>  
> 

Reviewed-by: Sinan Kaya <okaya@...eauora.org>



-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.