linux-kernel - [PATCH 3/3] perf report: fill per-callchain symbol annotation histograms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170417225520.28082-4-alexis.berlemont@gmail.com>
Date:   Tue, 18 Apr 2017 00:55:20 +0200
From:   Alexis Berlemont <alexis.berlemont@...il.com>
To:     linux-kernel@...r.kernel.org
Cc:     Alexis Berlemont <alexis.berlemont@...il.com>,
        peterz@...radead.org, mingo@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com
Subject: [PATCH 3/3] perf report: fill per-callchain symbol annotation histograms

The per-callchain histograms must be fed at some points with the
profiling samples. A solution is to fill them right after having filled
the per-symbol ones: in the callback hist_iter__report_callback.

Signed-off-by: Alexis Berlemont <alexis.berlemont@...il.com>
---
 tools/perf/builtin-report.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index c18158b83eb1..d825a599d4b4 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -136,6 +136,14 @@ static int hist_iter__report_callback(struct hist_entry_iter *iter,
 		if (single)
 			err = hist_entry__inc_addr_samples(he, evsel->idx,
 							   al->addr);
+		if (err == 0) {
+			struct callchain_cursor *cursor = &callchain_cursor;
+
+			err = hist_entry_cxt__inc_addr_samples(he,
+							       evsel->idx,
+							       al->addr,
+							       cursor);
+		}
 	} else {
 		err = hist_entry__inc_addr_samples(he, evsel->idx, al->addr);
 	}
-- 
2.12.2