linux-kernel - Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170418075131.GA15328@botnar.kaiser.cx>
Date:   Tue, 18 Apr 2017 09:51:31 +0200
From:   Martin Kaiser <martin@...ser.cx>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc
 entry

Thus wrote Greg Kroah-Hartman (gregkh@...uxfoundation.org):

> > -	ret = proc_create("misc", 0, NULL, &misc_proc_fops);
> > +	ret = proc_create("misc", 0444, NULL, &misc_proc_fops);

> What checkpatch warning does this fix?  0 is a number :)

ERROR: Use 4 digit octal (0777) not decimal permissions
#285: FILE: drivers/char/misc.c:285:
+  ret = proc_create("misc", 0, NULL, &misc_proc_fops);

Best regards,

   Martin