linux-kernel - Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1492511561.8661.34.camel@perches.com>
Date:   Tue, 18 Apr 2017 03:32:41 -0700
From:   Joe Perches <joe@...ches.com>
To:     Greg KH <greg@...ah.com>, Chewie Lin <linsh@...gonstate.edu>
Cc:     forest@...ttletooquiet.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device_reset

On Tue, 2017-04-18 at 10:33 +0200, Greg KH wrote:
> On Tue, Apr 18, 2017 at 01:24:37AM -0700, Chewie Lin wrote:
> > Removed the usb_device_reset(), replace with call to usb_reset_device() 
> > directly. Plus it removes the confusing function name and addressed 
> > the checkpatch warning as well by swap string in the dev_warn() call with 
> > __func__ argument, instead of explicitly calling the function name in 
> > the string:
> > 
> >         WARNING: Prefer using "%s", __func__ to embedded function names
> >         #417: FILE: main_usb.c:417:
> >         +                        "usb_device_reset fail status=%d\n", status);
> > 
> >         total: 0 errors, 1 warnings, 1058 lines checked
> > 
> > And after fix:
> > 
> >          main_usb.c has no obvious style problems and is ready for submission.
> > 
> > 
> > Signed-off-by: Chewie Lin <linsh@...gonstate.edu>
> 
> Your subject line is odd, don't you think?  Compare it to other patches
> for this driver and please fix it up and resend.
> 
> And there's never a need for a 0/X email for a single patch submission,
> no need to do that again.

And __func__ here is vt6656_probe not usb_reset_device.

usb_reset_device is the function that failed.