linux-kernel - Re: [PATCH] staging : rtl8188eu : remove void function return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1492516989.8661.36.camel@perches.com>
Date:   Tue, 18 Apr 2017 05:03:09 -0700
From:   Joe Perches <joe@...ches.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        surenderpolsani <surenderpolsani@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging : rtl8188eu : remove void function return

On Tue, 2017-04-18 at 13:52 +0200, Greg KH wrote:
> On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote:
> > kernel coding style doesn't allow the return statement
> > in void function.
> > 
> > Signed-off-by: surenderpolsani <surenderpolsani@...il.com>
> 
> I need a "real" name here, and in the from line please.  Use what you
> use to sign documents.

You'll also need a patch that compiles properly.

void foo(void)
{
	goto bar;
bar:
}

doesn't compile with gcc.

This patch removes the required statement after the
label immediately before the function end.

It could be replaced by just a semicolon which is
done a few places in the kernel or just left as-is.