linux-kernel - Re: [PATCH 0/4] Handle memmap and mem kernel options in boot stage kaslr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Apr 2017 14:51:54 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Baoquan He <bhe@...hat.com>
Cc:     linux-kernel@...r.kernel.org, keescook@...omium.org,
        dave.jiang@...el.com, dan.j.williams@...el.com, hpa@...or.com,
        tglx@...utronix.de, dyoung@...hat.com
Subject: Re: [PATCH 0/4] Handle memmap and mem kernel options in boot stage
 kaslr


* Baoquan He <bhe@...hat.com> wrote:

> On 04/18/17 at 11:47am, Ingo Molnar wrote:
> > 
> > * Baoquan He <bhe@...hat.com> wrote:
> > 
> > > People reported kernel panic occurs during system boots up with mem boot option.
> > > After checking code, several problems are found about memmap= and mem= in boot stage
> > > kaslr.
> > > 
> > > *) In commit f28442497b5c ("x86/boot: Fix KASLR and memmap= collision"), only one memmap
> > >    entry is considered and only the last one if multiple memmap entries are specified.
> > > 
> > > *) mem= and memmap=nn[KMG] are not considered yet. They are used to limit max address
> > >    of system. Kernel can't be randomized to be above the limit.
> > > 
> > > *) kernel-parameters.txt doesn't tell the updated behaviour of memmap=.
> > > 
> > > This patchset tries to solve above issues.
> > > 
> > > Baoquan He (4):
> > >   param: Move function next_arg to lib/cmdline.c for later reuse
> > >   KASLR: Parse all memmap entries in cmdline
> > >   KASLR: Handle memory limit specified by memmap and mem option
> > >   doc: Update description about memmap option in kernel-parameter.txt
> > > 
> > >  Documentation/admin-guide/kernel-parameters.txt |   9 ++
> > >  arch/x86/boot/compressed/cmdline.c              |   2 +-
> > >  arch/x86/boot/compressed/kaslr.c                | 161 ++++++++++++++----------
> > >  arch/x86/boot/string.c                          |   8 ++
> > >  include/linux/kernel.h                          |   1 +
> > >  kernel/params.c                                 |  52 --------
> > >  lib/cmdline.c                                   |  57 +++++++++
> > >  7 files changed, 172 insertions(+), 118 deletions(-)
> > 
> > I ported this series to tip:x86/boot (please post future versions against that), 
> > and beyond a trivial conflict with e820entry => e820_entry, it fails to build on 
> > 32-bit allmodconfig:
> > 
> >   ld: -r and -shared may not be used together
> >   scripts/Makefile.build:294: recipe for target 'arch/x86/boot/compressed/kaslr.o' failed
> > 
> > ... which could be due to bad relocations, but I've not dug any further.
> 
> Thanks, Ingo!
> 
> I will find a x86_32 system to try allmodconfig.

No need, on a 64-bit system just do:

	make ARCH=i386 allmodconfig

and build the kernel the regular way.

Thanks,

	Ingo