linux-kernel - Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170418142126.GE27592@e104818-lin.cambridge.arm.com>
Date:   Tue, 18 Apr 2017 15:21:26 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Stefano Stabellini <sstabellini@...nel.org>
Cc:     xen-devel@...ts.xen.org, jgross@...e.com, will.deacon@....com,
        linux-kernel@...r.kernel.org, linux@...linux.org.uk,
        Julien Grall <julien.grall@....com>,
        boris.ostrovsky@...cle.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18
 "Consolidate get_dma_ops..."

On Thu, Apr 13, 2017 at 02:04:21PM -0700, Stefano Stabellini wrote:
> The following commit:
> 
>   commit 815dd18788fe0d41899f51b91d0560279cf16b0d
>   Author: Bart Van Assche <bart.vanassche@...disk.com>
>   Date:   Fri Jan 20 13:04:04 2017 -0800
> 
>       treewide: Consolidate get_dma_ops() implementations
> 
> rearranges get_dma_ops in a way that xen_dma_ops are not returned when
> running on Xen anymore, dev->dma_ops is returned instead (see
> arch/arm/include/asm/dma-mapping.h:get_arch_dma_ops and
> include/linux/dma-mapping.h:get_dma_ops).
> 
> Fix the problem by storing dev->dma_ops in dev_archdata, and setting
> dev->dma_ops to xen_dma_ops. This way, xen_dma_ops is returned naturally
> by get_dma_ops. The Xen code can retrieve the original dev->dma_ops from
> dev_archdata when needed. It also allows us to remove __generic_dma_ops
> from common headers.
> 
> Signed-off-by: Stefano Stabellini <sstabellini@...nel.org>
> Tested-by: Julien Grall <julien.grall@....com>
> Suggested-by: Catalin Marinas <catalin.marinas@....com>
> CC: linux@...linux.org.uk
> CC: catalin.marinas@....com
> CC: will.deacon@....com
> CC: boris.ostrovsky@...cle.com
> CC: jgross@...e.com
> CC: Julien Grall <julien.grall@....com>

Reviewed-by: Catalin Marinas <catalin.marinas@....com>