linux-kernel - RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from atomic_t to refcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2236FBA76BA1254E88B949DDB74E612B41C8C6EB@IRSMSX102.ger.corp.intel.com>
Date:   Tue, 18 Apr 2017 14:29:43 +0000
From:   "Reshetova, Elena" <elena.reshetova@...el.com>
To:     Bjorn Helgaas <bhelgaas@...gle.com>
CC:     Stephen Hemminger <stephen@...workplumber.org>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Kees Cook <keescook@...omium.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "Hans Liljestrand" <ishkamiel@...il.com>,
        David Windsor <dwindsor@...il.com>
Subject: RE: [PATCH 17/29] drivers, pci: convert hv_pci_dev.refs from
 atomic_t to refcount_t

> On Tue, Apr 18, 2017 at 5:40 AM, Reshetova, Elena
> <elena.reshetova@...el.com> wrote:
> >
> >
> >> On Mon, 6 Mar 2017 15:38:29 -0600
> >> Bjorn Helgaas <helgaas@...nel.org> wrote:
> >>
> >> > [+cc Hyper-V folks, -cc others]
> >> >
> >> > On Mon, Mar 06, 2017 at 04:21:04PM +0200, Elena Reshetova wrote:
> >> > > refcount_t type and corresponding API should be
> >> > > used instead of atomic_t when the variable is used as
> >> > > a reference counter. This allows to avoid accidental
> >> > > refcounter overflows that might lead to use-after-free
> >> > > situations.
> >> > >
> >> > > Signed-off-by: Elena Reshetova <elena.reshetova@...el.com>
> >> > > Signed-off-by: Hans Liljestrand <ishkamiel@...il.com>
> >> > > Signed-off-by: Kees Cook <keescook@...omium.org>
> >> > > Signed-off-by: David Windsor <dwindsor@...il.com>
> >>
> >>
> >> Reviewed-by: Stephen Hemminger <sthemmin@...rosoft.com>
> >
> > Getting back on this: could you take the patch via your tree or should I resubmit
> to some dedicated place with a new review-by added?
> 
> Sorry, for some reason I had assumed this would all go as part of the
> larger series.  I applied it to my pci/host-hv branch with Stephen's
> reviewed-by for v4.12.

Thank you very much! I think I confused everyone in the beginning, but later on we decided that it is better off in small chunks and separate tress. 

Best Regards,
Elena.
> 
> Thanks for the ping!
> 
> Bjorn