linux-kernel - Re: [PATCH] ASoC: dwc: disallow building designware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170418151834.c7e5fivmgn73sbwd@sirena.org.uk>
Date:   Tue, 18 Apr 2017 16:18:34 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Jose Abreu <Jose.Abreu@...opsys.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module

On Tue, Apr 18, 2017 at 12:59:54PM +0200, Lubomir Rintel wrote:
> It makes not sense: the whether the PIO PCM extension is used is
> hardcoded to the designware_i2s driver and designware_pcm doesn't
> have any module metadata, causing a kernel taint:
> 
>   [   44.287000] designware_pcm: module license 'unspecified' taints kernel.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>

This is not a a good approach, there is no technical reason to force the
driver to be built in.  If you need a license tag in the module then add
that.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)