linux-kernel - Re: [PATCH] usb: Make sure usb/phy/of gets built-in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58F584C9.3050607@gmail.com>
Date:   Mon, 17 Apr 2017 20:15:21 -0700
From:   Frank Rowand <frowand.list@...il.com>
To:     Alexey Brodkin <Alexey.Brodkin@...opsys.com>,
        linux-usb@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Nicolas Pitre <nicolas.pitre@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Felipe Balbi <balbi@...nel.org>, Felix Fietkau <nbd@....name>,
        Jeremy Kerr <jk@...abs.org>,
        linux-snps-arc@...ts.infradead.org, stable@...r.kernel.org,
        Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH] usb: Make sure usb/phy/of gets built-in

On 04/13/17 05:33, Alexey Brodkin wrote:
> DWC3 driver uses of_usb_get_phy_mode() which is
> implemented in drivers/usb/phy/of.c and in bare minimal
> configuration it might not be pulled in kernel binary.
> 
> In case of ARC or ARM this could be easily reproduced with
> "allnodefconfig" +CONFIG_USB=m +CONFIG_USB_DWC3=m.
> 
> On building all ends-up with:
> ---------------------->8------------------
>   Kernel: arch/arm/boot/Image is ready
>   Kernel: arch/arm/boot/zImage is ready
>   Building modules, stage 2.
>   MODPOST 5 modules
> ERROR: "of_usb_get_phy_mode" [drivers/usb/dwc3/dwc3.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> ---------------------->8------------------
> 
> Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: Nicolas Pitre <nicolas.pitre@...aro.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Felipe Balbi <balbi@...nel.org>
> Cc: Felix Fietkau <nbd@....name>
> Cc: Jeremy Kerr <jk@...abs.org>
> Cc: linux-snps-arc@...ts.infradead.org
> Cc: stable@...r.kernel.org
> ---
>  drivers/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 2eced9afba53..8f8bdc9e3d29 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -104,6 +104,7 @@ obj-$(CONFIG_USB_PHY)		+= usb/
>  obj-$(CONFIG_USB)		+= usb/
>  obj-$(CONFIG_PCI)		+= usb/
>  obj-$(CONFIG_USB_GADGET)	+= usb/

> +obj-$(CONFIG_OF)		+= usb/

Would CONFIG_USB_SUPPORT make more sense? (And does it work?)


>  obj-$(CONFIG_SERIO)		+= input/serio/
>  obj-$(CONFIG_GAMEPORT)		+= input/gameport/
>  obj-$(CONFIG_INPUT)		+= input/
>