linux-kernel - Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for tegra124 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d18b57d3-a44f-e44b-9bd5-526993dc91e4@wwwdotorg.org>
Date:   Tue, 18 Apr 2017 10:15:45 -0600
From:   Stephen Warren <swarren@...dotorg.org>
To:     Paul Kocialkowski <contact@...lk.fr>, linux-kernel@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>
Cc:     alsa-devel@...a-project.org, linux-tegra@...r.kernel.org,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Alexandre Courbot <gnurou@...il.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for
 tegra124 SoC

On 04/18/2017 09:11 AM, Paul Kocialkowski wrote:
> This selects the tegra30 i2s and ahub controllers for the tegra124 SoC.
> These are needed when building without ARCH_TEGRA_3x_SOC set.

> diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
> index efbe8d4c019e..bcd18d2cf7a7 100644
> --- a/sound/soc/tegra/Kconfig
> +++ b/sound/soc/tegra/Kconfig
> @@ -46,7 +46,7 @@ config SND_SOC_TEGRA20_SPDIF
>
>  config SND_SOC_TEGRA30_AHUB
>  	tristate
> -	depends on SND_SOC_TEGRA && ARCH_TEGRA_3x_SOC
> +	depends on SND_SOC_TEGRA && (ARCH_TEGRA_3x_SOC || ARCH_TEGRA_124_SOC)

Is this really a compile-time dependency? If so, don't we need to add 
T210 and T186 entries into that || condition too, since we could be 
building a kernel with just T210/T186 support and no T124 support?