[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bb45bf45-8f42-c169-32f3-6987b2d44de2@users.sourceforge.net>
Date: Tue, 18 Apr 2017 18:53:29 +0200
From: SF Markus Elfring <elfring@...rs.sourceforge.net>
To: linux-acpi@...r.kernel.org, Borislav Petkov <bp@...e.de>,
Chun-Yi Lee <joeyli.kernel@...il.com>,
Colin Ian King <colin.king@...onical.com>,
Dan Williams <dan.j.williams@...el.com>,
Len Brown <lenb@...nel.org>,
Linda Knippers <linda.knippers@....com>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Tony Luck <tony.luck@...el.com>,
Vishal Verma <vishal.l.verma@...el.com>,
Zhang Rui <rui.zhang@...el.com>
Cc: LKML <linux-kernel@...r.kernel.org>,
kernel-janitors@...r.kernel.org
Subject: [PATCH 3/6] ACPI-nfit: Use devm_kcalloc() in nfit_mem_dcr_init()
From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Tue, 18 Apr 2017 17:30:15 +0200
* A multiplication for the size determination of a memory allocation
indicated that an array data structure should be processed.
Thus use the corresponding function "devm_kcalloc".
* Replace the specification of a data structure by a pointer dereference
to make the corresponding size determination a bit safer according to
the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
drivers/acpi/nfit/core.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index 462e77272272..1aa625dc424a 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -809,9 +809,11 @@ static int nfit_mem_dcr_init(struct acpi_nfit_desc *acpi_desc,
continue;
nfit_mem->nfit_flush = nfit_flush;
flush = nfit_flush->flush;
- nfit_mem->flush_wpq = devm_kzalloc(acpi_desc->dev,
- flush->hint_count
- * sizeof(struct resource), GFP_KERNEL);
+ nfit_mem->flush_wpq
+ = devm_kcalloc(acpi_desc->dev,
+ flush->hint_count,
+ sizeof(*nfit_mem->flush_wpq),
+ GFP_KERNEL);
if (!nfit_mem->flush_wpq)
return -ENOMEM;
for (i = 0; i < flush->hint_count; i++) {
--
2.12.2
Powered by blists - more mailing lists