linux-kernel - Re: [PATCH v4 5/5] perf report: Show branch type in callchain entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170418185314.GA15584@krava>
Date:   Tue, 18 Apr 2017 20:53:14 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jin Yao <yao.jin@...ux.intel.com>
Cc:     acme@...nel.org, jolsa@...nel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com,
        Linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        kan.liang@...el.com, yao.jin@...el.com,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v4 5/5] perf report: Show branch type in callchain entry

On Wed, Apr 12, 2017 at 06:21:06AM +0800, Jin Yao wrote:

SNIP

> +static int branch_type_str(struct branch_type_stat *stat,
> +			   char *bf, int bfsize)
> +{
> +	int i, j = 0, printed = 0;
> +	u64 total = 0;
> +
> +	for (i = 0; i < PERF_BR_MAX; i++)
> +		total += stat->counts[i];
> +
> +	if (total == 0)
> +		return 0;
> +
> +	printed += scnprintf(bf + printed, bfsize - printed, " (");
> +
> +	if (stat->jcc_fwd > 0) {
> +		j++;
> +		printed += scnprintf(bf + printed, bfsize - printed,
> +				     "JCC forward");
> +	}
> +
> +	if (stat->jcc_bwd > 0) {
> +		if (j++)
> +			printed += scnprintf(bf + printed, bfsize - printed,
> +					     " JCC backward");
> +		else
> +			printed += scnprintf(bf + printed, bfsize - printed,
> +					     "JCC backward");
> +	}
> +
> +	if (stat->cross_4k > 0) {
> +		if (j++)
> +			printed += scnprintf(bf + printed, bfsize - printed,
> +					     " CROSS_4K");
> +		else
> +			printed += scnprintf(bf + printed, bfsize - printed,
> +					     "CROSS_4K");
> +	}

could that 2 legs if be shortened to just one scnprintf like (untested):

   printed += scnprintf(bf + printed, bfsize - printed, "%s%s", j++ ? " " : "", "CROSS_4K");

I'd also probably use some kind of macro or function
with all that similar code, but I dont insist ;-)

thanks,
jirka